Updating k8s deps to v1.31 #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
robscott
commented
Sep 16, 2024
Comment on lines
-495
to
+449
| type of condition in CamelCase or in foo.example.com/CamelCase. | ||
| --- | ||
| Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be | ||
| useful (see .node.status.conditions), the ability to deconflict is important. | ||
| The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt) | ||
| description: type of condition in CamelCase or in foo.example.com/CamelCase. |
There was a problem hiding this comment.
Lots of deletions in CRD spec here which explains the large overall diff. In most cases, this is removing whitespace, but in some cases, this is removing some part of the description.
This was referenced Sep 16, 2024
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Takes care of #3340, #3337, and #3336
Does this PR introduce a user-facing change?: