chore: add conformance suite client options #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass options to the Kubernetes client
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XS
howardjohn
reviewed
Sep 17, 2024
| @@ -234,6 +236,7 @@ func NewConformanceTestSuite(options ConformanceOptions) (*ConformanceTestSuite, | |||
|
|
|||
| suite := &ConformanceTestSuite{ | |||
| Client: options.Client, | |||
There was a problem hiding this comment.
Is there much point allowing someone to pass in a Client anymore if its going to be ignored anyways?
There was a problem hiding this comment.
This is a fair comment. It should be removed
There was a problem hiding this comment.
Would a follow up PR be suitable?
howardjohn
approved these changes
Sep 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BobyMCbobs, howardjohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
/kind bug
/kind cleanup
/area conformance
What this PR does / why we need it:
pass options to the Kubernetes client to allow for things like schema and mapper.
Which issue(s) this PR fixes:
Fixes #3342
Does this PR introduce a user-facing change?: