-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conformance coredns deployment #3389
base: main
Are you sure you want to change the base?
Conversation
The deployment would fail on OpenShift due to missing capabilities
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: asmigala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @asmigala! |
Hi @asmigala. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Hi @howardjohn Could you check if there is anything that prevents from merging this PR, please? |
Hello @howardjohn @candita Could you response, please? Is there anything that prevents from merging this? |
@MaxBab we haven't found this to be an issue. What version/s and platform are you testing? |
Hello @candita This issue happens on Openshift platform. |
Let's chat. I sent you a slack message. |
@asmigala Can you fix the language and commit comment that makes it seem like it's the only way that conformance reports will run on OpenShift. This helps OpenShift, but isn't the only way to do it and thus isn't required by all OpenShift testing. Seems like it's not really a bug, in my opinion. /lgtm |
/area conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be reasonable for us to just change the port and update the svc targetPort?
/kind bug
What this PR does / why we need it:
This PR fixes conformance test when running on OpenShift. The coredns deployment required by some tests would fail to start due to missing
NET_BIND_SERVICE
capability-->