Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated e2e script to better handle focus and skip #108

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

rjsadow
Copy link
Collaborator

@rjsadow rjsadow commented Jan 18, 2024

This should help resolve an issue where focus is being passed without a focus set.

ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/hydrophone-e2e-check/1747986869506805760#1:build-log.txt%3A110-138

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 18, 2024
@rjsadow rjsadow force-pushed the fix-e2e branch 2 times, most recently from 4f91729 to 4779b22 Compare January 18, 2024 16:23
Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
@rjsadow rjsadow merged commit 9320879 into kubernetes-sigs:main Jan 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants