Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed github workflow periodics in favor of prow #115

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

rjsadow
Copy link
Collaborator

@rjsadow rjsadow commented Jan 20, 2024

Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@rjsadow: GitHub didn't allow me to request PR reviews from the following users: rakshitgondwal.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

fixes: #86

The hack/run-e2e.sh script now works as expected to replace all of our github actions workflows with prow. Periodic conformance and e2e workflows are now successfully running as expected in prow.

Conformance:

Expected results with github actions: https://github.com/kubernetes-sigs/hydrophone/actions/runs/7592586907/job/20682101706#step:9:40
Results in prow: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/hydrophone-conformance-check/1748530959478689792#1:build-log.txt%3A141
Testgrid: https://testgrid.k8s.io/sig-testing-misc#hydrophone-conformance-check

E2E:

Expected results with github actions: https://github.com/kubernetes-sigs/hydrophone/actions/runs/7592595767/job/20682123463#step:9:42
Results in prow: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/hydrophone-e2e-check/1748621557107789824#1:build-log.txt%3A141
Testgrid: https://testgrid.k8s.io/sig-testing-misc#hydrophone-e2e-check

/cc @dims @rakshitgondwal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2024
@dims
Copy link
Member

dims commented Jan 20, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 241565a into kubernetes-sigs:main Jan 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from github actions to prow
3 participants