Added development.md #121

NaveenGokavarapu19 · 2024-01-22T01:35:34Z

No description provided.

k8s-ci-robot · 2024-01-22T01:35:44Z

Hi @NaveenGokavarapu19. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rjsadow · 2024-01-22T14:54:20Z

development.md

Lets rename this file from development.md to DEVELOPMENT.md. This would be more consistent in the naming convention of important files across the project.

We shouldn't move the entire README.md file into this file. Rather, lets move in the Build, Run, Troubleshooting, and Cleanup sections. Still keep the Prerequisites section as well.

I'm still seeing the file name as development.md instead of DEVELOPMENT.md. Can you please update the file name?

I have renamed it.

rjsadow · 2024-01-22T14:54:37Z

development.md

+## PREREQUISITES
+- [go](https://go.dev/dl/)
+- [git](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
+ect.


Remove this line and replace it with a kind and a link to installing kind.

rjsadow · 2024-01-22T14:55:02Z

development.md

+
+### Get Started with Development 
+#
+## PREREQUISITES


Change from PREREQUISITES to Prerequisites

reetasingh · 2024-01-24T02:43:40Z

DEVELOPMENT.md

+
+
+
+### Get Started with Development 


nit:

Suggested change

### Get Started with Development

### Getting Started

reetasingh · 2024-01-24T02:44:37Z

DEVELOPMENT.md

+
+
+### Get Started with Development 
+#


this # looks unnecessary

…e unecessary lines

rjsadow · 2024-01-25T14:51:16Z

Hi Naveen, please rebase and then we'll merge.

NaveenGokavarapu19 · 2024-01-27T03:24:22Z

unable to rebase due to merge conflicts and unable to locate which file is causing the conflict.

NaveenGokavarapu19 · 2024-01-31T15:41:29Z

please review the changes and merge the request
@reetasingh @rjsadow @

DEVELOPMENT.md

rakshitgondwal

Some nit picks @NaveenGokavarapu19

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

NaveenGokavarapu19 · 2024-02-01T02:43:38Z

Some nit picks @NaveenGokavarapu19

Done the changes @rakshitgondwal

rakshitgondwal · 2024-02-01T08:46:45Z

DEVELOPMENT.md

+
+
+
+
+


These extra lines need to be deleted at the end.

DEVELOPMENT.md

reetasingh · 2024-02-02T03:23:26Z

/ok-to-test

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

rjsadow · 2024-02-06T10:40:22Z

/lgtm
/approve

k8s-ci-robot · 2024-02-06T10:40:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NaveenGokavarapu19, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rjsadow]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Added development.md

1f43f2a

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2024

k8s-ci-robot requested review from dims and rjsadow January 22, 2024 01:35

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2024

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2024

rjsadow reviewed Jan 22, 2024

View reviewed changes

NaveenGokavarapu19 and others added 2 commits January 23, 2024 20:32

made the changes in development and readme.md

af778e4

Rename development.md to DEVELOPMENT.md

3c46e05

reetasingh reviewed Jan 24, 2024

View reviewed changes

Renamed getting started with development to getting started and remov…

c5784fc

…e unecessary lines

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024

Merge branch 'main' into development-addition

bcd8566

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2024

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

DEVELOPMENT.md Show resolved Hide resolved

rakshitgondwal reviewed Jan 31, 2024

View reviewed changes

Update DEVELOPMENT.md

fb65ef3

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

NaveenGokavarapu19 and others added 7 commits February 1, 2024 08:11

Update DEVELOPMENT.md

3d23a59

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

a0ec1db

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

21dbecb

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

c3dacde

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

e9ba7a7

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

5923fc3

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

8510748

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

rakshitgondwal reviewed Feb 1, 2024

View reviewed changes

DEVELOPMENT.md

Comment on lines +106 to +110

Copy link

Member

rakshitgondwal Feb 1, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extra lines need to be deleted at the end.

rakshitgondwal reviewed Feb 1, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Feb 1, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Feb 1, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

rakshitgondwal reviewed Feb 1, 2024

View reviewed changes

DEVELOPMENT.md Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2024

NaveenGokavarapu19 and others added 4 commits February 6, 2024 06:15

Update DEVELOPMENT.md

edb25e3

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

16827f2

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

a78a372

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

Update DEVELOPMENT.md

5e82f4b

Co-authored-by: Rakshit Gondwal <98955085+rakshitgondwal@users.noreply.github.com>

k8s-ci-robot assigned rjsadow Feb 6, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024

k8s-ci-robot merged commit dd06e32 into kubernetes-sigs:main Feb 6, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added development.md #121

Added development.md #121

NaveenGokavarapu19 commented Jan 22, 2024

k8s-ci-robot commented Jan 22, 2024

rjsadow Jan 22, 2024

NaveenGokavarapu19 Jan 23, 2024

rjsadow Jan 23, 2024

NaveenGokavarapu19 Jan 23, 2024

rjsadow Jan 22, 2024

NaveenGokavarapu19 Jan 23, 2024

rjsadow Jan 22, 2024

NaveenGokavarapu19 Jan 23, 2024

reetasingh Jan 24, 2024

NaveenGokavarapu19 Jan 24, 2024

reetasingh Jan 24, 2024

NaveenGokavarapu19 Jan 24, 2024

rjsadow commented Jan 25, 2024

NaveenGokavarapu19 commented Jan 27, 2024

NaveenGokavarapu19 commented Jan 31, 2024

rakshitgondwal left a comment

NaveenGokavarapu19 commented Feb 1, 2024

rakshitgondwal Feb 1, 2024 •

edited

Loading

reetasingh commented Feb 2, 2024

rjsadow commented Feb 6, 2024

k8s-ci-robot commented Feb 6, 2024

Added development.md #121

Added development.md #121

Conversation

NaveenGokavarapu19 commented Jan 22, 2024

k8s-ci-robot commented Jan 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjsadow commented Jan 25, 2024

NaveenGokavarapu19 commented Jan 27, 2024

NaveenGokavarapu19 commented Jan 31, 2024

rakshitgondwal left a comment

Choose a reason for hiding this comment

NaveenGokavarapu19 commented Feb 1, 2024

rakshitgondwal Feb 1, 2024 • edited Loading

Choose a reason for hiding this comment

reetasingh commented Feb 2, 2024

rjsadow commented Feb 6, 2024

k8s-ci-robot commented Feb 6, 2024

rakshitgondwal Feb 1, 2024 •

edited

Loading