Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the readme file #124

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Updated the readme file #124

merged 5 commits into from
Feb 13, 2024

Conversation

AryanSharma9917
Copy link
Contributor

This PR fixes - #111

@AryanSharma9917
Updated the readme file
1ad6c86 
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @AryanSharma9917!

It looks like this is your first PR to kubernetes-sigs/hydrophone 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hydrophone has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @AryanSharma9917. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2024
rjsadow
rjsadow reviewed Jan 23, 2024
View reviewed changes
README.md Outdated
@@ -118,7 +118,7 @@ kubectl delete -n conformance pods/e2e-conformance-test && kubectl delete ns con
Please reach out for bugs, feature requests, and other issues!
The maintainers of this project are reachable via:

- [Kubernetes Slack] in the [#sig-testing] and [#k8s-conformance] channels
- [Hydrophone Slack] in the [#sig-testing] and [#k8s-conformance] channels
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep the Kubernetes Slack link as is since that's the overarching slack community and will guide folks on getting into slack if they've not logged in before.

We should add #hydrophone similar to how we list #sig-testing and #k8s-conformance.

@rjsadow
Copy link
Collaborator

rjsadow commented Jan 23, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2024
@AryanSharma9917
Made some changes
79b4a45 
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
rakshitgondwal
rakshitgondwal reviewed Jan 27, 2024
View reviewed changes
README.md Outdated
Comment on lines 121 to 122
- [Kubernetes Slack] in the [#sig-testing] and [#k8s-conformance] channels
- [Hydrophone Slack] in the [#sig-testing] and [#k8s-conformance] channels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [Kubernetes Slack] in the [#sig-testing] and [#k8s-conformance] channels
- [Hydrophone Slack] in the [#sig-testing] and [#k8s-conformance] channels
- [Kubernetes Slack] in the [#hydrophone], [#sig-testing] and [#k8s-conformance] channels.

rakshitgondwal
rakshitgondwal reviewed Jan 27, 2024
View reviewed changes
README.md Outdated
@@ -147,6 +148,7 @@ Participation in the Kubernetes community is governed by the [Kubernetes Code of
[@rjsadow]: https://github.com/rjsadow
[filing an issue]: https://sigs.k8s.io/hydrophone/issues/new
[Kubernetes Slack]: http://slack.k8s.io/
[Hydrophone Slack]: https://kubernetes.slack.com/archives/C06E3NPR4A3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Hydrophone Slack]: https://kubernetes.slack.com/archives/C06E3NPR4A3

rakshitgondwal
rakshitgondwal reviewed Jan 27, 2024
View reviewed changes
Copy link
Member

@rakshitgondwal rakshitgondwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#hydrophone is a sub channel of the k8s slack. We can mention it in the same way we are mentioning #sig-testing and #k8s-conformance I believe.

@kundan2707
Copy link
Contributor

@AryanSharma9917 squash multiple commits into one.

@AryanSharma9917
Made some changes
759813f
@AryanSharma9917
Made some changes
273043b
@AryanSharma9917
Updated readme.md file
1755f85 
Signed-off-by: aryansharma9917 <sharmaaryan9837@gmail.com>
rjsadow
rjsadow reviewed Feb 9, 2024
View reviewed changes
README.md
@@ -146,7 +146,7 @@ Participation in the Kubernetes community is governed by the [Kubernetes Code of
[@dims]: https://github.com/dims
[@rjsadow]: https://github.com/rjsadow
[filing an issue]: https://sigs.k8s.io/hydrophone/issues/new
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AryanSharma9917 Are you able to accept @rakshitgondwal change?

@rakshitgondwal rakshitgondwal mentioned this pull request Feb 13, 2024
Closed
@rakshitgondwal
Copy link
Member

/lgtm
we can get this merged, the blockers for this PR are getting resolved in #152

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Feb 13, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AryanSharma9917, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit b648ff7 into kubernetes-sigs:main Feb 13, 2024
7 checks passed
@xrstf xrstf mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakshitgondwal rakshitgondwal rakshitgondwal left review comments

@rjsadow rjsadow rjsadow left review comments

@dims dims Awaiting requested review from dims

Assignees

@rakshitgondwal rakshitgondwal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AryanSharma9917 @k8s-ci-robot @rjsadow @kundan2707 @rakshitgondwal