Added separate verify scripts and boilerplate #130
Conversation
|
@rjsadow: GitHub didn't allow me to request PR reviews from the following users: rakshitgondwal, reetasingh. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
|
@reetasingh: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -0,0 +1,76 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
@rjsadow curious - do all the scripts under the hack/ directory run as part of the prow CI or needs to be configured somewhere on which one needs to run
There was a problem hiding this comment.
Right now all of our CI runs by these definitions https://github.com/kubernetes/test-infra/tree/master/config/jobs/kubernetes-sigs/hydrophone. This PR will update our repo and should run verify-all.sh script because I've now updated make verify. Here's the specific job definition for verify. https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/hydrophone/hydrophone-presubmit.yaml#L47-L68
rjsadow
force-pushed
the
verify-all
branch
2 times, most recently
from
96500eb to
df77c9a
Compare
Signed-off-by: rjsadow <richard.j.sadowski@gmail.com>
|
@reetasingh can you re-lgtm this please? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Add additional verification steps that are more in line with other projects.
/cc @dims @reetasingh @rakshitgondwal