test: add tests for args.go

[rakshitgondwal]

Adds additional test cases for args.go in args_test.go.

[rakshitgondwal]

@rjsadow Can you please have a look why the tests are failing, cant figure it out.

[rjsadow]

Understanding where/how this line came to be: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_hydrophone/140/pull-hydrophone-simple-run/1751961702041128960#1:build-log.txt%3A139. If you also look at line 144, at the end there's a ,[] at the end. That shouldn't be there.

[rjsadow]

I'm guessing we're not handling a case properly when extra-args are empty.

[rakshitgondwal]

Facing a really weird behaviour, the tests here are running properly with the current changes but while trying test this out locally, it is showing an error.

Trying to run: bin/hydrophone --focus 'Simple pod should contain last line of the log'

and getting

23:26:06 INF API endpoint : https://127.0.0.1:44729
23:26:06 INF Server version : version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.3", GitCommit:"25b4e43193bcda6c7328a6d147b1fb73a33f1598", GitTreeState:"clean", BuildDate:"2023-06-15T00:36:28Z", GoVersion:"go1.20.5", Compiler:"gc", Platform:"linux/amd64"}
panic: interface conversion: interface {} is []interface {}, not []string

goroutine 1 [running]:
sigs.k8s.io/hydrophone/pkg/common.ValidateArgs()
        /home/rakshit/Desktop/hydrophone/pkg/common/args.go:62 +0x6f9
sigs.k8s.io/hydrophone/cmd.glob..func1(0xc0001a5600?, {0x1a08856?, 0x4?, 0x1a0885a?})
        /home/rakshit/Desktop/hydrophone/cmd/root.go:64 +0x85
github.com/spf13/cobra.(*Command).execute(0x29309e0, {0xc00011a100, 0x2, 0x2})
        /home/rakshit/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:987 +0xaa3
github.com/spf13/cobra.(*Command).ExecuteC(0x29309e0)
        /home/rakshit/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1115 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        /home/rakshit/go/pkg/mod/github.com/spf13/cobra@v1.8.0/command.go:1039
sigs.k8s.io/hydrophone/cmd.Execute()
        /home/rakshit/Desktop/hydrophone/cmd/root.go:82 +0x1a
main.main()
        /home/rakshit/Desktop/hydrophone/main.go:24 +0xf

Not just with this branch, but facing the same behavior with the main branch.

Any thoughts on this? @rjsadow @reetasingh

[reetasingh]

--focus 'Simple pod should contain last line of the log'

strange. not getting error same from main

reeta@Reetas-MacBook-Pro hydrophone % go run main.go --focus 'Simple pod should contain last line of the log'
12:09:05 INF API endpoint : https://127.0.0.1:50108
12:09:05 INF Server version : version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-19T15:42:59Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/arm64"}
12:09:05 INF Using conformance image : 'registry.k8s.io/conformance:v1.24.0'
12:09:05 INF Using busybox image : 'registry.k8s.io/e2e-test-images/busybox:1.36.1-1'
12:09:05 INF Test framework will start '1' threads and use verbosity '4'
12:09:05 INF namespace created conformance

12:09:05 INF serviceaccount created conformance-serviceaccount

12:09:05 INF clusterrole created conformance-serviceaccount

12:09:05 INF clusterrolebinding created conformance-serviceaccount-role

12:09:05 INF pod created e2e-conformance-test

2024/01/29 20:09:05 Running command:
Command env: []
Run from directory: 
Executable path: /usr/local/bin/ginkgo
Args (comma-delimited): /usr/local/bin/ginkgo,--focus=Simple pod should contain last line of the log,--skip=,--noColor=true,/usr/local/bin/e2e.test,--,--disable-log-dump,--repo-root=/kubernetes,--provider=skeleton,--report-dir=/tmp/results,--kubeconfig=
2024/01/29 20:09:05 Now listening for interrupts
I0129 20:09:05.957930      25 e2e.go:129] Starting e2e run "5817a123-d977-45cc-a22d-0a40398cc836" on Ginkgo node 1
{"msg":"Test Suite starting","total":1,"completed":0,"skipped":0,"failed":0}
Running Suite: Kubernetes e2e suite

1. when running from main branch did you run make build again?
2. the issue would be mostly coming from https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/common/args.go#L62 if extra-args is not of type []string but of type []interafce{}

[rakshitgondwal]

when running from main branch did you run make build again?

Yep.

the issue would be mostly coming from https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/common/args.go#L62 if extra-args is not of type []string but of type []interafce{}

This check should not be running in this case right? as I have not defined any extraArgs.

If there is no extraArgs defined, the value of that flag inside config is [], and in the logic we are checking extraArgs != "", maybe this is what is causing the error?

[reetasingh]

when running from main branch did you run make build again?

Yep.

the issue would be mostly coming from https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/common/args.go#L62 if extra-args is not of type []string but of type []interafce{}

This check should not be running in this case right? as I have not defined any extraArgs.

If there is no extraArgs defined, the value of that flag inside config is [], and in the logic we are checking extraArgs != "", maybe this is what is causing the error?

this will help #141

[rakshitgondwal]

/hold wait for #141 to be merged first

[reetasingh]

/hold wait for #141 to be merged first

@rakshitgondwal PTAL #141 , added a cleaner solution. Thanks for highlighting the problem

[rakshitgondwal]

/hold cancel

[reetasingh]

/lgtm

[rjsadow]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rakshitgondwal, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rjsadow]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment