Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set an empty key tolerations to match all tains on node #153

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 14, 2024

During conformance testing nodes might get various tains set, to ensure the test pod survives all possibilities we're setting appropriate toleration which will match all possible taints.

/assign @rjsadow

During conformance testing nodes might get various tains set, to ensure
the test pod survives all possibilities we're setting appropriate
toleration which will match all possible taints.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Feb 15, 2024

/lgtm
/approve
Thanks @soltysh!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8f5985b into kubernetes-sigs:main Feb 15, 2024
7 checks passed
@soltysh soltysh deleted the tolerations branch February 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants