Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging for clusterrole and clusterbinding #162

Merged

Conversation

Bharadwajshivam28
Copy link
Contributor

fixes #161

In previous when clusterrole and clusterrolebinding were present then both were logged exists one and created one both.

Previous action-
Screenshot from 2024-02-19 23-14-09

Current action-
Screenshot from 2024-02-19 23-16-44

Signed-off-by: shivam <shivambharadwaj822@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Bharadwajshivam28. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2024
@Bharadwajshivam28
Copy link
Contributor Author

Hey @rakshitgondwal I saw that same issue was for clusterrolebinding also so I have made the changes in both clusterrolebinding and clusterrole

@rakshitgondwal
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2024
Copy link
Member

@rakshitgondwal rakshitgondwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also rework the logic for cleanup

@Bharadwajshivam28
Copy link
Contributor Author

Hey @rakshitgondwal When i tried with --cleanup the logging was not correct.

The current behaviour-
Screenshot from 2024-02-20 14-44-14

The expected behaviour should be-
Screenshot from 2024-02-20 14-55-23

@Bharadwajshivam28
Copy link
Contributor Author

I have made the changes and fixed it just need to push it

@rakshitgondwal
Copy link
Member

Please do @Bharadwajshivam28

@Bharadwajshivam28
Copy link
Contributor Author

Please do @Bharadwajshivam28

Okay...

Signed-off-by: shivam <shivambharadwaj822@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2024
@Bharadwajshivam28
Copy link
Contributor Author

I have modified the lines which fixes it.. Please review it and if any changes is required then we can do it @rakshitgondwal

@rjsadow
Copy link
Collaborator

rjsadow commented Feb 27, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bharadwajshivam28, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit a54a903 into kubernetes-sigs:main Feb 27, 2024
7 checks passed
@Bharadwajshivam28 Bharadwajshivam28 deleted the Improving_logging branch September 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging for resource creation
4 participants