-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved logging for clusterrole and clusterbinding #162
Improved logging for clusterrole and clusterbinding #162
Conversation
Signed-off-by: shivam <shivambharadwaj822@gmail.com>
Hi @Bharadwajshivam28. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @rakshitgondwal I saw that same issue was for clusterrolebinding also so I have made the changes in both clusterrolebinding and clusterrole |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also rework the logic for cleanup
Hey @rakshitgondwal When i tried with --cleanup the logging was not correct. |
I have made the changes and fixed it just need to push it |
Please do @Bharadwajshivam28 |
Okay... |
Signed-off-by: shivam <shivambharadwaj822@gmail.com>
I have modified the lines which fixes it.. Please review it and if any changes is required then we can do it @rakshitgondwal |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bharadwajshivam28, rjsadow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #161
In previous when clusterrole and clusterrolebinding were present then both were logged exists one and created one both.
Previous action-
Current action-