use golangci-lint as linter

[embik]

golangci-lint is a pretty good linter for Go projects. This updates the existing hack/verify-golint.sh script to install that instead of golang.org/x/lint/golint.

The .golangci.yml configuration file is adapted from https://github.com/kubernetes-sigs/krew/blob/master/.golangci.yml. Felt like a pretty good starting point, we can gradually enable linters that seem useful.

This PR is currently a WIP because the new linter uncovers a couple of problems, but some of them are already addressed in #165. I'll wait for that PR to move forward (in any direction) before fixing linter-discovered problems in this PR to minimise conflict with the existing PR.

[k8s-ci-robot]

Welcome @embik!

It looks like this is your first PR to kubernetes-sigs/hydrophone 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hydrophone has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @embik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rjsadow]

/lgtm
/approve
Thanks! I was wanting to move to golangci-lint.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rjsadow]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[embik]

level=error msg="Running error: context loading failed: no go files to analyze: running go mod tidy may solve the problem"

Will look into why this is happening. make verify works fine on my local system, I'll see what is the difference to the prow job.

[embik]

I've fixed the linter issues post-merge of #165, but I'm not sure why the prow job was failing in the first place. Tried to reproduce it by running public.ecr.aws/docker/library/golang:1.22, which was happily executing make verify.

@rjsadow PR is ready for review now, so maybe this could get an ok-to-test? If the job keeps failing I might need to push 1-2 debug commits to dissect the job environment.

[rjsadow]

/ok-to-test

[xmudrii]

/retest

[embik]

It was a timeout issue due to the constrained nature of the prow job. I'll open a PR in test-infra to bump the job to 2 cpu cores. But it works now.

[rjsadow]

/lgtm

[rjsadow]

/hold

[rjsadow]

@embik This looks good, but can you please remove the error handling changes from this PR? I think we've got some other issues and PRs that are looking to update some of that which might conflict.

[embik]

@embik This looks good, but can you please remove the error handling changes from this PR? I think we've got some other issues and PRs that are looking to update some of that which might conflict.

I can do that, but then I'll still need to add //nolint directives which might also result in conflicts. I currently don't see any PRs open that relate to this, #165 by my colleague @xrstf was changing a lot of error handling but it's already merged and I rebased this PR accordingly.

Do you still want me to go ahead with that?

[embik]

@rjsadow realised you can just add //nolint to a whole file, so I've put a temporary one in place for cmd/root.go. Should be good to go now!

[rjsadow]

@embik looks good,thanks for doing this!
/lgtm