Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append namespace to resources to allow parallel conformance tests #171

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 3, 2024

This PR makes it possible to run hydrophone concurrently in the same cluster by appending its namespace to the cluster-wide resource names (e.g. the ClusterRole hydrophone becomes hydrophone:<namespace>). I also fixed some leftover hardcoded names and changed the cleanup logic to just delete the namespace, letting Kubernetes take care of garbage collection.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 3, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xrstf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 3, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Apr 3, 2024

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2024
@dims
Copy link
Member

dims commented Apr 4, 2024

/assign @rjsadow @reetasingh

@reetasingh
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Apr 6, 2024

@xrstf this looks good to me. I would like to add a test for this, we can add a parameter in hack/run_e2e.sh to set a namespace then create a presubmit to run a simple test In a set namespace. If you'd like to update the script in this pr or another that would be great, if not I'm happy to get to it later.

/lgtm
/approve
/hold
Feel free to remove the hold when you're ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2024
@xrstf
Copy link
Contributor Author

xrstf commented Apr 7, 2024

@rjsadow I've added the NAMESPACE parameter to the script and rebased the PR. :) Will create the presubmit afterwards.

@@ -48,25 +48,26 @@ function run_test {
--output-dir ${ARTIFACTS}/results/ \
--focus "${FOCUS}" \
--skip "${SKIP}" \
$EXTRA_ARGS| tee /tmp/test.log

--namespace "${NAMESPACE}" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it be an issue if namespace is set to an empty string? I don't see any validation to set it to the default. Does Viper take care of this somehow?

Copy link
Contributor Author

@xrstf xrstf Apr 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the same logic we already have for the FOCUS/SKIP/DRY_RUN variables further down. Besides the kind stuff, I can run the run-e2e.sh locally just fine. Also, the presubmits in this PR succeeded, so it should be fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, let's give it a shot.

@rjsadow
Copy link
Collaborator

rjsadow commented Apr 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2024
@xrstf
Copy link
Contributor Author

xrstf commented Apr 7, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit a691b1b into kubernetes-sigs:main Apr 7, 2024
7 checks passed
@xrstf xrstf deleted the multi-runs branch April 7, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants