-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
append namespace to resources to allow parallel conformance tests #171
Conversation
Hi @xrstf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/assign @rjsadow @reetasingh |
/lgtm |
@xrstf this looks good to me. I would like to add a test for this, we can add a parameter in /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rjsadow I've added the |
@@ -48,25 +48,26 @@ function run_test { | |||
--output-dir ${ARTIFACTS}/results/ \ | |||
--focus "${FOCUS}" \ | |||
--skip "${SKIP}" \ | |||
$EXTRA_ARGS| tee /tmp/test.log | |||
|
|||
--namespace "${NAMESPACE}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be an issue if namespace is set to an empty string? I don't see any validation to set it to the default. Does Viper take care of this somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the same logic we already have for the FOCUS/SKIP/DRY_RUN variables further down. Besides the kind stuff, I can run the run-e2e.sh
locally just fine. Also, the presubmits in this PR succeeded, so it should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, let's give it a shot.
/lgtm |
/hold cancel |
This PR makes it possible to run hydrophone concurrently in the same cluster by appending its namespace to the cluster-wide resource names (e.g. the ClusterRole
hydrophone
becomeshydrophone:<namespace>
). I also fixed some leftover hardcoded names and changed the cleanup logic to just delete the namespace, letting Kubernetes take care of garbage collection.