Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide spinner on -v <= 2, show test logs in realtime with -v >= 6 #176

Merged
merged 3 commits into from
Apr 7, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 7, 2024

This PR makes more use of the --verbosity flag.

  • The default value, 4, is kept with the same behaviour: Show a spinner.
  • If v <= 2, then no spinner is shown, useful for e2e jobs.
  • If v >= 6, then the spinner is replaced with the live test output.

This would fix #168.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xrstf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Apr 7, 2024

Great idea and addition!
/ok-to-test
/lgtm
/approved
/hold
Remove hold when tests pass and you're ready to merge.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2024
@xrstf
Copy link
Contributor Author

xrstf commented Apr 7, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2024
@xrstf
Copy link
Contributor Author

xrstf commented Apr 7, 2024

@rjsadow I think you meant /approve 😀

@dims
Copy link
Member

dims commented Apr 7, 2024

/approve

( casting for @rjsadow :) )

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9009565 into kubernetes-sigs:main Apr 7, 2024
7 checks passed
@xrstf xrstf deleted the verbosity branch April 7, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use --verbosity to toggle between spinner and verbose Ginkgo output
4 participants