Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant gofmt check #184

Merged

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 20, 2024

golangci-lint already includes gofmt. If I break the formatting in the main.go:

$ hack/verify-gofmt.sh
!!! 'gofmt -s' needs to be run on the following files:
./main.go

$ hack/verify-golint.sh
main.go:20: File is not `gofmt`-ed with `-s` (gofmt)
"sigs.k8s.io/hydrophone/cmd"

Just running the gofmt check is marginally faster, but I would presume that anyone aware enough to actually run it, already has configured their editor appropriately to not need it. And those who don't get caught by the existing golint checker in the presubmit job. 😁

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2024
@xrstf xrstf marked this pull request as ready for review April 20, 2024 19:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 20, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Apr 21, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit c49a138 into kubernetes-sigs:main Apr 21, 2024
8 checks passed
@xrstf xrstf deleted the remove-redundant-gofmt-check branch April 21, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants