download a precompiled golangci-lint to save CI time #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
xrstf
force-pushed
the
use-precompiled-golangci-lint
branch
from
b86e3c8
to
2d3f891
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
do-not-merge/work-in-progress
xrstf
force-pushed
the
use-precompiled-golangci-lint
branch
from
2d3f891
to
4950dfd
Compare
|
/test pull-hydrophone-verify |
xrstf
force-pushed
the
use-precompiled-golangci-lint
branch
from
4950dfd
to
732a427
Compare
|
/test pull-hydrophone-verify |
1 similar comment
|
/test pull-hydrophone-verify |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's really no good need to spend all that time compiling golangci-lint everytime a commit is tested.
This saves roughly a minute in CI.