-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: image version matching #99
feat: image version matching #99
Conversation
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Hi @rakshitgondwal. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
/approve This looks great! I want to take a few minutes to test it myself before putting on an lgtm. I'll make some time this afternoon to verify it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rakshitgondwal, rjsadow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sure, thanks @rjsadow |
Try running |
looks good to me @rakshitgondwal, let's fix the |
Signed-off-by: Rakshit Gondwal <rakshitgondwal3@gmail.com>
Fixed, please check @rjsadow |
/lgtm |
Thanks for the merge! |
Description
Fixes #94
Adds the functionality to automatically set the conformance image version to match the k8s cluster version by default.
A user can still explicitly define an image using
--conformance-image
flag if they want to.Screenshots
Default behavior. Automatically fetches the image according to the cluster version, i.e
v1.27.3
:Behavior if
--conformance-image
has been defined. In this casev1.29.0
: