Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore /etc/resolv.conf symlink on Flatcar CAPI Azure images #1347

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Restore /etc/resolv.conf symlink on Flatcar CAPI Azure images #1347

merged 1 commit into from
Nov 30, 2023

Conversation

invidian
Copy link
Member

What this PR does / why we need it:

Restore /etc/resolv.conf symlink after waagent deprovisioning on Flatcar so built images have proper DNS resolution until flatcar/Flatcar#1265 is addressed.

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Closes #1346

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
@invidian invidian mentioned this pull request Nov 29, 2023
Closed
@mboersma
Copy link
Contributor

mboersma commented Nov 29, 2023 •
edited
Loading

@invidian, this lgtm but needs the commit message changed apparently. Maybe drop the path at the beginning so it's just restore /etc/resolv.conf on Flatcar?

@invidian invidian force-pushed the invidian/fix-resolv-conf-on-flatcar branch from d69d36f to 2c7720f Compare November 29, 2023 18:23
@invidian
Copy link
Member Author

Would Restore /etc/resolv.conf symlink on Flatcar CAPI Azure images be acceptable?

@invidian
Restore /etc/resolv.conf symlink on Flatcar CAPI Azure images
db2e951 
Refs kubernetes-sigs#1346

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
@invidian invidian force-pushed the invidian/fix-resolv-conf-on-flatcar branch from 2c7720f to db2e951 Compare November 29, 2023 18:24
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 29, 2023
@invidian invidian changed the title images/capi/packer/azure/packer.json: restore /etc/resolv.conf on Flatcar Restore /etc/resolv.conf symlink on Flatcar CAPI Azure images Nov 29, 2023
mboersma
mboersma reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2023
@mboersma
Copy link
Contributor

mboersma commented Nov 29, 2023 •
edited
Loading

/retest

Sign into Azure
Create storage account
ERROR: Please run 'az login' to setup account.

Sign-in must have failed for this whole job, but didn't raise an error?

Edit: worked on second try.

AverageMarcus
AverageMarcus reviewed Nov 30, 2023
View reviewed changes
Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @invidian :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit aee4798 into kubernetes-sigs:main Nov 30, 2023
@invidian invidian deleted the invidian/fix-resolv-conf-on-flatcar branch November 30, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma left review comments

@AverageMarcus AverageMarcus AverageMarcus left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@mboersma mboersma

@AverageMarcus AverageMarcus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flatcar Azure images are booting with broken /etc/resolv.conf
4 participants
@invidian @mboersma @k8s-ci-robot @AverageMarcus