Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dl.k8s.io instead of hardcoded GCS URIs #656

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 17, 2021

What this PR does / why we need it:

The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if gsutil is being used (e.g. gsutil cp gs://foo/bar .)

Otherwise, for tools like curl or wget, dl.k8s.io is much nicer for us
as a project, since we can transparently change where that redirects to
without having to change code everywhere

These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release -> gs://k8s-release migration equivalent of
the CI migration we're going through right now

These changes also address the gs://kubernetes-release-dev references
currently used by this repo (ref:
kubernetes/k8s.io#2318)

While I was here, I updated images/capi/hack/image-new-kube.py to run
with python3. I assumed this was OK since I saw sibling scripts using
python3

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
This is similar to the PR I've opened for cluster-api: kubernetes-sigs/cluster-api#4958

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2021
@spiffxp spiffxp changed the title Use dl.k8s.io instead of hardcoded GCS bucket URIs Use dl.k8s.io instead of hardcoded GCS URIs Jul 17, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 17, 2021

/cc @CecileRobertMichon @sbueringer @randomvariable
Since I requested review from y'all on kubernetes-sigs/cluster-api#4958

@spiffxp
Copy link
Member Author

spiffxp commented Jul 19, 2021

/cc @cpanato
Since you've got some familiarity with this codebase and reviewed some of the other related PR's in this area

@cpanato
Copy link
Member

cpanato commented Jul 19, 2021

/cc @cpanato
Since you've got some familiarity with this codebase and reviewed some of the other related PR's in this area

Will review, thanks for the heads up!

@sbueringer
Copy link
Member

Change looks reasonable to me, but I'm not really familiar with the codebase

@CecileRobertMichon
Copy link
Contributor

/retest

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont see anything that hurt my eyes :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 19, 2021

/cc @hakman @rifelpet
for images/kube-deploy

@CecileRobertMichon
Copy link
Contributor

blocked by OVA CI

/cc @codenrhoden

@rifelpet
Copy link

/lgtm for images/kube-deploy

@rifelpet
Copy link

/approve

@cpanato
Copy link
Member

cpanato commented Jul 20, 2021

/test pull-ova-all

@cpanato
Copy link
Member

cpanato commented Jul 20, 2021

saw this: vsphere: ServerFaultCode: Cannot complete login due to an incorrect user name or password.

will take a look at this job and config, I'm not familiar with vsphere

@cpanato
Copy link
Member

cpanato commented Jul 20, 2021

@codenrhoden
Copy link
Contributor

/lgtm
The OVA job shouldn't be blocking anymore. Will be working to sort that out this week.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, rifelpet, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 20, 2021

@spiffxp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-ova-all db0f4fa link /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spiffxp
Copy link
Member Author

spiffxp commented Jul 20, 2021

/test pull-azure-vhds
since I think this was a flake
/override pull-ova-all
using my github admin superpowers

I'm honestly not sure why tide is paying attention to either of these if they're not marked as required in the UI

@spiffxp
Copy link
Member Author

spiffxp commented Jul 20, 2021

Not sure why https://prow.k8s.io/command-help#override didn't work, let's try https://prow.k8s.io/command-help#skip

/skip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants