-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dl.k8s.io instead of hardcoded GCS URIs #656
Conversation
use f-strings and single quotes
there were simple enough to merely search-replace vs the script in previous commits
/cc @CecileRobertMichon @sbueringer @randomvariable |
/cc @cpanato |
Will review, thanks for the heads up! |
Change looks reasonable to me, but I'm not really familiar with the codebase |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont see anything that hurt my eyes :)
/lgtm
blocked by OVA CI /cc @codenrhoden |
/lgtm for |
/approve |
/test pull-ova-all |
saw this: will take a look at this job and config, I'm not familiar with vsphere |
being discussed here: https://kubernetes.slack.com/archives/C01E0Q35A8J/p1626725388053700 |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, rifelpet, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@spiffxp: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-azure-vhds I'm honestly not sure why tide is paying attention to either of these if they're not marked as |
Not sure why https://prow.k8s.io/command-help#override didn't work, let's try https://prow.k8s.io/command-help#skip /skip |
What this PR does / why we need it:
The only time a kubernetes GCS bucket name should be showing up in a
hardcoded URI is if
gsutil
is being used (e.g. gsutil cp gs://foo/bar .)Otherwise, for tools like
curl
orwget
, dl.k8s.io is much nicer for usas a project, since we can transparently change where that redirects to
without having to change code everywhere
These changes will mean no changes will be necessary to accommodate a
gs://kubernetes-release
->gs://k8s-release
migration equivalent ofthe CI migration we're going through right now
These changes also address the
gs://kubernetes-release-dev
referencescurrently used by this repo (ref:
kubernetes/k8s.io#2318)
While I was here, I updated
images/capi/hack/image-new-kube.py
to runwith
python3
. I assumed this was OK since I saw sibling scripts usingpython3
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
This is similar to the PR I've opened for cluster-api: kubernetes-sigs/cluster-api#4958