fix AMI names for CAPI AMI image build #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign detiber |
detiber
reviewed
Oct 7, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaroniscode, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 2 fixes to the AMI names for the CAPI AMI image build:
Currently, the name of the AMI for Ubuntu, CentOS and Amazon Linux 2 are taken from
kubernetes_deb_versionvariable. If a user is only building CentOS and/or Amazon Linux 2, the name of the deb version is not relevant. This updates the CentOS and Amazon Linux images to use thekubernetes_rpm_version.If the
kubernetes_rpm_versionorkubernetes_rpm_versioncontainers an invalid AMI character like a+, packer will error. One use case for this is the VMware binaries. This PR uses packer'sclean_resource_namewhich will replace invalid character with a-.