split refactor from kubectl vaidate

kubernetes-sigs · Mar 28, 2024 · a92cd68 · a92cd68
1 parent e8e75e4
commit a92cd68
Showing 1 changed file with 0 additions and 64 deletions.
diff --git a/pkg/webhooks/jobset_webhook_test.go b/pkg/webhooks/jobset_webhook_test.go
@@ -815,70 +815,6 @@ func TestValidateCreate(t *testing.T) {
 				fmt.Errorf(podNameTooLongErrorMsg),
 			),
 		},
-		{
-			name: "missing containers",
-			js: &jobset.JobSet{
-				TypeMeta: metav1.TypeMeta{
-					Kind:       "JobSet",
-					APIVersion: "jobset.x-k8s.io/v1alpha2",
-				},
-				ObjectMeta: validObjectMeta,
-				Spec: jobset.JobSetSpec{
-					ReplicatedJobs: []jobset.ReplicatedJob{
-						{
-							Name:     "rj",
-							Replicas: 1,
-							Template: batchv1.JobTemplateSpec{
-								Spec: batchv1.JobSpec{
-									Template: corev1.PodTemplateSpec{
-										Spec: corev1.PodSpec{},
-									},
-								},
-							},
-						},
-					},
-					SuccessPolicy: &jobset.SuccessPolicy{
-						Operator: jobset.OperatorAll,
-					},
-				},
-			},
-			want: errors.Join(
-				fmt.Errorf(
-					"spec.replicatedJobs[0].template.spec.template.spec.containers: Invalid value: \"null\": spec.replicatedJobs[0].template.spec.template.spec.containers in body must be of type array",
-				),
-			),
-		},
-		{
-			name: "invalid success policy",
-			js: &jobset.JobSet{
-				TypeMeta: metav1.TypeMeta{
-					Kind:       "JobSet",
-					APIVersion: "jobset.x-k8s.io/v1alpha2",
-				},
-				ObjectMeta: validObjectMeta,
-				Spec: jobset.JobSetSpec{
-					ReplicatedJobs: []jobset.ReplicatedJob{
-						{
-							Name:     "rj",
-							Replicas: 1,
-							Template: batchv1.JobTemplateSpec{
-								Spec: batchv1.JobSpec{
-									Template: validPodTemplateSpec,
-								},
-							},
-						},
-					},
-					SuccessPolicy: &jobset.SuccessPolicy{
-						Operator: "InvalidOperator",
-					},
-				},
-			},
-			want: errors.Join(
-				fmt.Errorf(
-					"spec.successPolicy.operator: Unsupported value: \"InvalidOperator\": supported values: \"All\", \"Any\"",
-				),
-			),
-		},
 	}
 	fakeClient := fake.NewFakeClient()
 	webhook, err := NewJobSetWebhook(fakeClient)