-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics to reflect controller health #53
Comments
does this issue urgent? might need some time to check how to implement metrics |
#60 is more urgent, can you remove the CEL validation and just validate inside the webhook? |
I need to check first, not sure if I know how to do it :( |
/assign |
Seems like Reconciliation Latency and Reconciliation Failures are already captured via controller-runtime prometheus metrics here: https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/internal/controller/metrics/metrics.go#L37-L44 |
/re-open We need to add docs explaining the couple of metrics you mentioned above, similar to https://kueue.sigs.k8s.io/docs/reference/metrics/ |
Possible metrics:
The text was updated successfully, but these errors were encountered: