Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid validation on Network field #60

Closed
ahg-g opened this issue Apr 24, 2023 · 4 comments
Closed

Invalid validation on Network field #60

ahg-g opened this issue Apr 24, 2023 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Apr 24, 2023

When not set, validation fails when creating a JobSet, I think something is wrong with the CEL validation at https://github.com/kubernetes-sigs/jobset/blob/main/api/v1alpha1/jobset_types.go#L83

Probably better to move this to the validation webhook, that validation line is hard to reason about.

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 24, 2023
@tenzen-y
Copy link
Member

Creating the integration tests for validation webhook might be worth it to avoid such bugs.

@ahg-g
Copy link
Contributor Author

ahg-g commented Apr 25, 2023

Yup, we have validation tests, but clearly not enough coverage.

@kannon92
Copy link
Contributor

#63 I believe solves this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@kannon92: Closing this issue.

In response to this:

#63 I believe solves this issue.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants