Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add troubleshooting docs #303

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Add troubleshooting docs #303

merged 5 commits into from
Sep 20, 2023

Conversation

danielvegamyhre
Copy link
Contributor

Fixes #302

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g September 20, 2023 19:31
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@danielvegamyhre
Copy link
Contributor Author

cc @kannon92

kannon92
kannon92 reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits.

I think we should maybe put FAQ by release or something. I worry that some of these would look dated over time. But this is mainly a suggestion.

docs/faq/README.md Outdated Show resolved Hide resolved
docs/faq/README.md Outdated Show resolved Hide resolved
docs/faq/README.md Outdated Show resolved Hide resolved
@danielvegamyhre @kannon92
Update docs/faq/README.md
a11b86e 
Co-authored-by: Kevin Hannon <kehannon@redhat.com>
ahg-g
ahg-g reviewed Sep 20, 2023
View reviewed changes
docs/faq/README.md Outdated Show resolved Hide resolved
danielvegamyhre and others added 3 commits September 20, 2023 13:56
@danielvegamyhre @ahg-g
Update docs/faq/README.md
cc96ded 
Co-authored-by: Abdullah Gharaibeh <40361897+ahg-g@users.noreply.github.com>
@danielvegamyhre @kannon92
Update docs/faq/README.md
33534c9 
Co-authored-by: Kevin Hannon <kehannon@redhat.com>
@danielvegamyhre
add example error
6b42acd
@kannon92
Copy link
Contributor

LGTM to me. I'll leave it for @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented Sep 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit a2a11f8 into kubernetes-sigs:main Sep 20, 2023
@danielvegamyhre danielvegamyhre mentioned this pull request Dec 12, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@kannon92 kannon92 kannon92 left review comments

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add FAQ for troubleshooting common issues
4 participants
@danielvegamyhre @k8s-ci-robot @kannon92 @ahg-g