Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-nominate kannon92 for a reviewer for jobset. #327

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Nov 7, 2023

I have been contributing to this project for a while now.

I am leading a KEP around startup policy and I have been an active contributor to this project.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2023
@danielvegamyhre
Copy link
Contributor

danielvegamyhre commented Nov 7, 2023

I am supportive of this, @ahg-g what do you think?

@kannon92
Copy link
Contributor Author

kannon92 commented Nov 7, 2023

/assign @ahg-g

@ahg-g
Copy link
Contributor

ahg-g commented Nov 10, 2023

/approve
/lgtm

Thanks Kevin!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7b7f9d5 into kubernetes-sigs:main Nov 10, 2023
@danielvegamyhre danielvegamyhre mentioned this pull request Dec 12, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants