add a message to events

[kannon92]

Events have a message.

We were neglecting the message so our events were a bit difficult to follow.

With this fix:

52s         Warning   Restarting                jobset/max-restarts                  restarting jobset, attempt 1
37s         Warning   Restarting                jobset/max-restarts                  restarting jobset, attempt 2
23s         Warning   Restarting                jobset/max-restarts                  restarting jobset, attempt 3
6s          Warning   Failed                    jobset/max-restarts                  ReachedMaxRestarts%!(EXTRA string=jobset failed due to reaching max number of restarts)

Without this fix:

52s         Warning   Restarting                jobset/max-restarts                 
37s         Warning   Restarting                jobset/max-restarts                  
23s         Warning   Restarting                jobset/max-restarts                 
6s          Warning   Failed                    jobset/max-restarts                  

[kannon92]

/assign @ahg-g @danielvegamyhre

Found this as I was working on the startup policy code. It may be worth considering a patch release but I'll leave that up to you two.

[kannon92]

/hold

So I was a bit wrong about this. We are dropping the message for events but for whatever reason, the reason is added in our events printing.

We see events like this actually. We don't have any detailed message for events but when I tried this change, I was seeing
5s Normal Completed jobset/success-policy ReachedMaxRestarts%!(EXTRA string=jobset failed due to reaching max number of restarts)

[kannon92]

Alright. I realized the problem.

Events (with this change)

5m12s       Normal    SuspendedJobs             jobset/paralleljobs                  jobset is suspended
4m18s       Normal    ResumeJobs                jobset/paralleljobs                  jobset is resumed
2m30s       Normal    AllJobsCompleted          jobset/paralleljobs                  jobset completed successfully
7m12s       Warning   Restarting                jobset/max-restarts                  restarting jobset, attempt 1
6m56s       Warning   Restarting                jobset/max-restarts                  restarting jobset, attempt 2
6m40s       Warning   Restarting                jobset/max-restarts                  restarting jobset, attempt 3
6m26s       Warning   ReachedMaxRestarts        jobset/max-restarts                  jobset failed due to reaching max number of restarts

[kannon92]

/hold cancel

[ahg-g]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment