Default service name in JobSet controller

[danielvegamyhre]

Fixes #394

[ahg-g]

/lgtm

[ahg-g]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahg-g,danielvegamyhre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kannon92]

@danielvegamyhre after this merge, I am seeing errors in the logs in our createJobs.

I see the following in the logs:

  2024-02-06T18:46:10-05:00     ERROR   creating jobs   {"controller": "jobset", "controllerGroup": "jobset.x-k8s.io", "controllerKind": "JobSet", "JobSet": {"name":"test-js","namespace":"jobset-ns-stqcv"}, "namespace": "jobset-ns-stqcv", "name": "test-js", "reconcileID": "4250eb7e-1660-4af4-a3b0-873b93aa85a4", "jobset": {"name":"test-js","namespace":"jobset-ns-stqcv"}, "error": "Service \"\" is invalid: metadata.name: Required value: name or generateName is required"}

[danielvegamyhre]

@danielvegamyhre after this merge, I am seeing errors in the logs in our createJobs.

I see the following in the logs:

  2024-02-06T18:46:10-05:00     ERROR   creating jobs   {"controller": "jobset", "controllerGroup": "jobset.x-k8s.io", "controllerKind": "JobSet", "JobSet": {"name":"test-js","namespace":"jobset-ns-stqcv"}, "namespace": "jobset-ns-stqcv", "name": "test-js", "reconcileID": "4250eb7e-1660-4af4-a3b0-873b93aa85a4", "jobset": {"name":"test-js","namespace":"jobset-ns-stqcv"}, "error": "Service \"\" is invalid: metadata.name: Required value: name or generateName is required"}

Can you paste that into an issue with a link to where you see that? I will take a look, thanks for bringing this up