Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jobset docsite #402

Merged
merged 1 commit into from
Feb 9, 2024
Merged

add jobset docsite #402

merged 1 commit into from
Feb 9, 2024

Conversation

moficodes
Copy link
Contributor

Part of #401

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 9, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Feb 9, 2024

/retest

Thanks Mofi, how can we view this?

@moficodes
Copy link
Contributor Author

Until netlify is setup only way would be to view locally.

I have a isssue in kubernetes orgs for netlify access. kubernetes/org#4748

If you want to run locally steps would

  • Install Hugo
  • cd site
  • npm install
  • hugo server

@ahg-g
Copy link
Contributor

ahg-g commented Feb 9, 2024

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, moficodes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@danielvegamyhre
Copy link
Contributor

This is great, thank you!

@k8s-ci-robot k8s-ci-robot merged commit 2b991b7 into kubernetes-sigs:main Feb 9, 2024
10 checks passed
@moficodes moficodes deleted the docsite branch February 10, 2024 03:24
@moficodes moficodes mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moficodes @ahg-g @k8s-ci-robot @danielvegamyhre