-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumping controller tools to see if this fixes ci #403
bumping controller tools to see if this fixes ci #403
Conversation
@@ -204,7 +204,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest | |||
|
|||
## Tool Versions | |||
KUSTOMIZE_VERSION ?= v3.8.7 | |||
CONTROLLER_TOOLS_VERSION ?= v0.11.4 | |||
CONTROLLER_TOOLS_VERSION ?= v0.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.12.0 is working for kueue, FWIIW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahg-g @danielvegamyhre wdyt?
I bumped it to the latest and the CI seems happy. It did generate a large diff from the CRD but not sure what impact the controller-tools provides for codegen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. Glancing over the CRD diff I don't see anything concerning
2fa7b70
to
680b019
Compare
/approve Thanks @kannon92 ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cherry-pick release-0.3 |
…-#403-upstream-release-0.3 Automated cherry pick of #403: bumping controller tools to see if this fixes ci
@kannon92, hi, I'm facing the same issue in my repo. Just a general question, how did you generate the |
I think I did both |
I noticed that we were segmentation faulting on controller-tools. We were using quite an old version so I wanted to see if this will fix the CI.
I don't think this is a dind issue as I originally thought.