Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping controller tools to see if this fixes ci #403

Merged

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Feb 9, 2024

I noticed that we were segmentation faulting on controller-tools. We were using quite an old version so I wanted to see if this will fix the CI.

I don't think this is a dind issue as I originally thought.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 9, 2024
@@ -204,7 +204,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest

## Tool Versions
KUSTOMIZE_VERSION ?= v3.8.7
CONTROLLER_TOOLS_VERSION ?= v0.11.4
CONTROLLER_TOOLS_VERSION ?= v0.14.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.12.0 is working for kueue, FWIIW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahg-g @danielvegamyhre wdyt?

I bumped it to the latest and the CI seems happy. It did generate a large diff from the CRD but not sure what impact the controller-tools provides for codegen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Glancing over the CRD diff I don't see anything concerning

@ahg-g
Copy link
Contributor

ahg-g commented Feb 9, 2024

/approve

Thanks @kannon92 !

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Feb 9, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit bda9370 into kubernetes-sigs:main Feb 9, 2024
10 checks passed
@kannon92 kannon92 mentioned this pull request Feb 13, 2024
5 tasks
@kannon92
Copy link
Contributor Author

/cherry-pick release-0.3

k8s-ci-robot added a commit that referenced this pull request Feb 13, 2024
…-#403-upstream-release-0.3

Automated cherry pick of #403: bumping controller tools to see if this fixes ci
@oliviassss
Copy link

@kannon92, hi, I'm facing the same issue in my repo. Just a general question, how did you generate the zz_generated.deepcopy.go after bumping up the controller-tools version? I ran make generate but nothing change in my local to commit, but my ci workflow indicates I need to update the zz_generated.deepcopy.go after I submit my PR.

@kannon92
Copy link
Contributor Author

@kannon92, hi, I'm facing the same issue in my repo. Just a general question, how did you generate the zz_generated.deepcopy.go after bumping up the controller-tools version? I ran make generate but nothing change in my local to commit, but my ci workflow indicates I need to update the zz_generated.deepcopy.go after I submit my PR.

I think I did both make generate manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants