Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add managed-by label support. #407

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add managed-by label support. #407

merged 4 commits into from
Feb 13, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Feb 12, 2024 •
edited
Loading

Add support for a new label alpha.jobset.sigs.k8s.io/managed-by which can be used to mark the JobSets that are managed by
another controller then the JobSet one.

The motivation and implementation are similar to the ones described in kubernetes/enhancements#4370 for batch/Job and used to implement MultiKueue support for JobSets in Kueue.

Fixes #379

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2024
kannon92
kannon92 reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @ahg-g @danielvegamyhre

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@kannon92 kannon92 mentioned this pull request Feb 12, 2024
Closed
@kannon92
Copy link
Contributor

kannon92 commented Feb 12, 2024 •
edited
Loading

Could you add a Fixes #379 to your description?

ahg-g
ahg-g reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

api/jobset/v1alpha2/jobset_webhook_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@ahg-g
Copy link
Contributor

ahg-g commented Feb 13, 2024

/label tide/merge-method-squash

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit fb8aa28 into kubernetes-sigs:main Feb 13, 2024
9 checks passed
@trasc trasc deleted the add-managed-by branch February 13, 2024 07:38
@tenzen-y tenzen-y mentioned this pull request Mar 4, 2024
Closed
@trasc trasc mentioned this pull request Mar 20, 2024
Merged
@danielvegamyhre danielvegamyhre mentioned this pull request Apr 10, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@kannon92 kannon92 kannon92 left review comments

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

Assignees

@kannon92 kannon92

@ahg-g ahg-g

@danielvegamyhre danielvegamyhre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trasc @kannon92 @ahg-g @k8s-ci-robot @danielvegamyhre