Move JobSet webhook into same webhooks package as pod webhook #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
needs-rebase
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
|
/retest |
k8s-ci-robot
removed
the
needs-rebase
danielvegamyhre
commented
Mar 20, 2024
danielvegamyhre
commented
Mar 20, 2024
Makefile
Outdated
| @@ -84,11 +84,11 @@ manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and Cust | |||
| rbac:roleName=manager-role output:rbac:artifacts:config=config/components/rbac\ | |||
| crd:generateEmbeddedObjectMeta=true output:crd:artifacts:config=config/components/crd/bases\ | |||
| webhook output:webhook:artifacts:config=config/components/webhook\ | |||
| paths="./..." | |||
| paths="{./api/..., ./pkg/...}" | |||
There was a problem hiding this comment.
Note: I had to change some Makefile rules to target specific paths rather than everything (./...) since it was picking up some javascript dependencies in the site/ directory, now that it is populated.
danielvegamyhre
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
kannon92
reviewed
Mar 21, 2024
kannon92
reviewed
Mar 21, 2024
kannon92
reviewed
Mar 21, 2024
kannon92
reviewed
Mar 21, 2024
kannon92
reviewed
Mar 21, 2024
kannon92
reviewed
Mar 21, 2024
|
/hold until I can talk to @alexzielenski when he is back from kubecon to learn more about kubectl-validate and it's roadmap for improved support for k8s native types |
k8s-ci-robot
added
do-not-merge/hold
danielvegamyhre
force-pushed
the
k-val
branch
3 times, most recently
from
a1e177f
to
f419e88
Compare
k8s-ci-robot
removed
the
needs-rebase
danielvegamyhre
changed the title
danielvegamyhre
changed the title
k8s-ci-robot
added
size/XL
danielvegamyhre
force-pushed
the
k-val
branch
3 times, most recently
from
0930d95
to
b012506
Compare
|
/hold cancel |
k8s-ci-robot
added
needs-rebase
|
Please rebase. Otherwise, lgtm. |
k8s-ci-robot
removed
the
needs-rebase
Finished rebasing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included in this PR:
v1alpha2) intopkg/webhookswith the pod webhook. This decoupling of the JobSet struct itself from the webhook used for JobSet defaulting/validation seemed necessary for a couple reasons:Validatorfield (from kubectl-validate) to the webhook for Investigate ways to validate Job templates at JobSet validation time #422 so we only create the OpenAPI client for kubectl-validate once, and I don't think the JobSet struct is the proper place for that openapi client based validator.