Move headless service creation outside of createJobs #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
kannon92
reviewed
Mar 28, 2024
| @@ -143,6 +143,11 @@ func (r *JobSetReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| } | |||
| } | |||
|
|
|||
| // If pod DNS hostnames are enabled, create a headless service for the JobSet | |||
| if err := r.createHeadlessSvcIfNecessary(ctx, &js); err != nil { | |||
There was a problem hiding this comment.
Maybe we could have a log here also?
There was a problem hiding this comment.
Added logging of the error here
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that headless service creation is inside the createJobs function is a relic of the first JobSet release where we created 1 headless service per replicatedJob.
When we changed this to 1 headless service per JobSet, we should have moved this outside of the createJobs function, to better follow the single responsibility principle. The headless service creation now has no dependency on jobs or replicated jobs so we should move it out to the main reconcile loops before job creation begins.