Add unit tests to jobset success policy functions

[zhifei92]

my first pr

Add unit tests to jobset success policy functions

Fixes #491

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: zhifei92 / name: panda (5dc8f18, 28eeae1, 7a36cf7, 2c52448)

[k8s-ci-robot]

Welcome @zhifei92!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @zhifei92. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name	Link
🔨 Latest commit	28eeae1
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/661743b9ec431f00085c8161

[zhifei92]

/easycla

[googs1025]

hi, Is this a duplicate pull request? #493

[danielvegamyhre]

Please use table-driven format to test different scenarios for a given function. Example:

jobset/pkg/controllers/startup_policy_test.go

Lines 25 to 45 in 8860f83

	tests := []struct {
	name string
	startupPolicy *jobset.StartupPolicy
	expected bool
	}{
	{
	name: "startup policy AnyOrder",
	startupPolicy: &jobset.StartupPolicy{StartupPolicyOrder: jobset.AnyOrder},
	expected: false,
	},
	{
	name: "startup policy InOrder",
	startupPolicy: &jobset.StartupPolicy{StartupPolicyOrder: jobset.InOrder},
	expected: true,
	},
	{
	name: "nil startup policy",
	startupPolicy: nil,
	expected: false,
	},
	}

[zhifei92]

Please use table-driven format to test different scenarios for a given function. Example:

jobset/pkg/controllers/startup_policy_test.go

Lines 25 to 45 in 8860f83

	tests := []struct {
	name string
	startupPolicy *jobset.StartupPolicy
	expected bool
	}{
	{
	name: "startup policy AnyOrder",
	startupPolicy: &jobset.StartupPolicy{StartupPolicyOrder: jobset.AnyOrder},
	expected: false,
	},
	{
	name: "startup policy InOrder",
	startupPolicy: &jobset.StartupPolicy{StartupPolicyOrder: jobset.InOrder},
	expected: true,
	},
	{
	name: "nil startup policy",
	startupPolicy: nil,
	expected: false,
	},
	}

get

[zhifei92]

hi, Is this a duplicate pull request? #493

Sorry, I didn't notice

[zhifei92]

/cc @danielvegamyhre @kannon92 hello, please help me review，thx

[zhifei92]

/easycla

[zhifei92]

@dejanzele fix again，thank you

[kannon92]

/ok-to-test

[kannon92]

Could you remove this line?

https://github.com/kubernetes-sigs/jobset/blob/main/pkg/controllers/success_policy.go#L24

[kannon92]

Once you address #501 (comment), LGTM.

/assign @danielvegamyhre

[zhifei92]

Could you remove this line?

https://github.com/kubernetes-sigs/jobset/blob/main/pkg/controllers/success_policy.go#L24

done

[danielvegamyhre]

/lgtm
/approve

Thanks for working on this!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, zhifei92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danielvegamyhre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment