Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #580: relax validation on replicated jobs #584

Conversation

danielvegamyhre
Copy link
Contributor

Cherry pick of #580 on release-0.5.
#580: relax validation on replicated jobs
For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g May 28, 2024 18:22
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kannon92 May 28, 2024 18:22
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
@danielvegamyhre
Copy link
Contributor Author

@omerap12 it seems the release branch presubmit is misconfigured, it fails to start with error could not start the process: exec: "runner.sh": executable file not found in $PATH. Can you please take a look?

@kannon92
Copy link
Contributor

Lgtm to me but the test failures seem concerning

@omerap12
Copy link
Member

@omerap12 it seems the release branch presubmit is misconfigured, it fails to start with error could not start the process: exec: "runner.sh": executable file not found in $PATH. Can you please take a look?

Yeah sure I'll take a look

@omerap12
Copy link
Member

Hey @danielvegamyhre @alculquicondor ,
I changed the command to much the golang image.
Here: kubernetes/test-infra#32680

@danielvegamyhre
Copy link
Contributor Author

/retest

@omerap12
Copy link
Member

@danielvegamyhre
Copy link
Contributor Author

/retest

@kannon92
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2024
@danielvegamyhre
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0436215 into kubernetes-sigs:release-0.5 May 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants