-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #580: relax validation on replicated jobs #584
Automated cherry pick of #580: relax validation on replicated jobs #584
Conversation
@omerap12 it seems the release branch presubmit is misconfigured, it fails to start with error |
Lgtm to me but the test failures seem concerning |
Yeah sure I'll take a look |
It looks like you forgot to change the image for the presubmit https://github.com/kubernetes/test-infra/blob/3c1c806d19d680b83e4f0a128f1d38641607d2ea/config/jobs/kubernetes-sigs/jobset/jobset-presubmit-release-0.5.yaml#L50 |
Hey @danielvegamyhre @alculquicondor , |
/retest |
Fixing . |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #580 on release-0.5.
#580: relax validation on replicated jobs
For details on the cherry pick process, see the cherry pick requests page.