Wait for the webhook service to be listening before advertising the Jobset replica as ready. #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
k8s-ci-robot
added
the
size/M
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @mimowo |
mbobrovskyi
force-pushed
the
feature/wait-for-the-webhook-service-to-be-listening-before-advertising-the-jobset-replica-as-ready
branch
from
09d3972 to
eadb91c
Compare
…obset replica as ready.
mbobrovskyi
force-pushed
the
feature/wait-for-the-webhook-service-to-be-listening-before-advertising-the-jobset-replica-as-ready
branch
from
eadb91c to
3c8290b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mbobrovskyi
deleted the
feature/wait-for-the-webhook-service-to-be-listening-before-advertising-the-jobset-replica-as-ready
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Wait for the webhook server to be listening before advertising the Jobset deployment replica as ready. This allows users to wait with sending the first requests, requiring webhooks, until the Jobset deployment is available, so that the early requests are not rejected during the Jobset's startup.
Which issue(s) this PR fixes:
Fixes #607
Special notes for your reviewer:
Does this PR introduce a user-facing change?