Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Used fixed API for Job Pod Failure Policy #620

Closed

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Jul 22, 2024

Bump the k8s/api to use the cherry-picks of the fix in kubernetes/kubernetes#126046 - it is going to released in 1.30.4 and 1.29.8, so for now using hash pointing to kubernetes/api@7c71f3c, which includes kubernetes/api@a63486c.

WIP because we probably want to wait until full release.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mimowo
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit a630811
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/669f75eb4596af0008d79747

@mimowo mimowo changed the title WIP: Used fixed API WIP: Used fixed API for Job Pod Failure Policy Jul 23, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@mimowo mimowo force-pushed the fix-job-pod-failure-api-sha1 branch 2 times, most recently from 2b1d6d0 to 113031d Compare July 23, 2024 08:56
@mimowo
Copy link
Contributor Author

mimowo commented Jul 23, 2024

/cc @danielvegamyhre @kannon92

@kannon92
Copy link
Contributor

LGTM but I think it would be best to wait for official patch release also.

@danielvegamyhre any objections?

@danielvegamyhre
Copy link
Contributor

LGTM but I think it would be best to wait for official patch release also.

@danielvegamyhre any objections?

I would prefer to watch for an official patch release as well, using a feature branch is a bit hacky and I want to prioritize production readiness and good engineering practices. The target date for 1.30.4 is 08-13-2024 which isn't an unreasonably long time. This bug is blocking the main use case of JobSet's new configurable failure policy (i.e., pairing JobSet failure policy rules with Pod failure policy rules to define more targeted restart/failure handling behavior), but I think we can wait until mid August for 0.6.0 release, and in the meantime perhaps include other important changes in 0.6.0, such as #618

@danielvegamyhre
Copy link
Contributor

Closing this in favor of waiting for proper patch release, see #620 (comment)

@mimowo
Copy link
Contributor Author

mimowo commented Jul 29, 2024

Closing this in favor of waiting for proper patch release, see #620 (comment)

Sure, makes sense. I opened it mostly to demonstrate e2e that the coming fix works. For the fix you can either use patch release of 1.29.8 or 1.30.4 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants