-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Used fixed API for Job Pod Failure Policy #620
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
2b1d6d0
to
113031d
Compare
113031d
to
a630811
Compare
LGTM but I think it would be best to wait for official patch release also. @danielvegamyhre any objections? |
I would prefer to watch for an official patch release as well, using a feature branch is a bit hacky and I want to prioritize production readiness and good engineering practices. The target date for 1.30.4 is 08-13-2024 which isn't an unreasonably long time. This bug is blocking the main use case of JobSet's new configurable failure policy (i.e., pairing JobSet failure policy rules with Pod failure policy rules to define more targeted restart/failure handling behavior), but I think we can wait until mid August for 0.6.0 release, and in the meantime perhaps include other important changes in 0.6.0, such as #618 |
Closing this in favor of waiting for proper patch release, see #620 (comment) |
Sure, makes sense. I opened it mostly to demonstrate e2e that the coming fix works. For the fix you can either use patch release of 1.29.8 or 1.30.4 . |
Bump the k8s/api to use the cherry-picks of the fix in kubernetes/kubernetes#126046 - it is going to released in 1.30.4 and 1.29.8, so for now using hash pointing to kubernetes/api@7c71f3c, which includes kubernetes/api@a63486c.
WIP because we probably want to wait until full release.