Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use symbolic link instead of directory #630

Merged
merged 2 commits into from
Sep 27, 2024
Merged

chore: use symbolic link instead of directory #630

merged 2 commits into from
Sep 27, 2024

Conversation

googs1025
Copy link
Member

  • use symbolic link instead of directory to avoid examples inconsistencies

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 27, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 9f9107a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66ed90ecff317d00081a3a94

@googs1025
Copy link
Member Author

/hold
When both PR #601 and PR #629 are merged, I will rebase again

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2024
@googs1025
Copy link
Member Author

Same as kueue project: https://github.com/kubernetes-sigs/kueue/blob/main/examples

@googs1025
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2024
@danielvegamyhre
Copy link
Contributor

Seems like this needs a rebase @googs1025

@googs1025
Copy link
Member Author

After this PR #601 is merged, I will rebase it together

@danielvegamyhre danielvegamyhre self-assigned this Aug 5, 2024
@danielvegamyhre
Copy link
Contributor

@googs1025 are you still working on this?

@danielvegamyhre danielvegamyhre added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 8, 2024
@googs1025
Copy link
Member Author

@googs1025 are you still working on this?

Yes, but I want to wait until the PR #601 is merged before making the changes. This will prevent the PR #601 from needing to be rebased.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@googs1025
Copy link
Member Author

Already ready for next !

@googs1025
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2024
@danielvegamyhre
Copy link
Contributor

@googs1025 why did you delete some of the examples, is that an accident? You may need to rebase

@googs1025
Copy link
Member Author

main: https://github.com/kubernetes-sigs/jobset/tree/main/site/static/examples
https://github.com/googs1025/jobset/tree/remove-example/site/static/examples

I checked and found that site/static/examples already has these examples. So those in examples/ can be deleted directly.
This way we don’t have to maintain two sets of examples, which can easily increase example inconsistencies.

@googs1025
Copy link
Member Author

@danielvegamyhre

@danielvegamyhre
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, googs1025

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit b92cbdc into kubernetes-sigs:main Sep 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees

@danielvegamyhre danielvegamyhre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@googs1025 @danielvegamyhre @k8s-ci-robot