Add new job-id annotation to assign globally unique job index to each job #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
danielvegamyhre
force-pushed
the
job-id
branch
from
f0bec34 to
4a54a30
Compare
danielvegamyhre
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
danielvegamyhre
changed the title
k8s-ci-robot
added
size/L
danielvegamyhre
force-pushed
the
job-id
branch
3 times, most recently
from
dbd60f5 to
32cc246
Compare
danielvegamyhre
force-pushed
the
job-id
branch
from
32cc246 to
1a0adbd
Compare
danielvegamyhre
added
the
tide/merge-method-squash
ahg-g
reviewed
Aug 15, 2024
api/jobset/v1alpha2/jobset_types.go
Outdated
| JobIndexKey string = "jobset.sigs.k8s.io/job-index" | ||
| // JobIDKey is a label/annotation set to an integer that is unique across the entire JobSet. | ||
| // For each JobSet, this value will range from 0 to N-1, where N=total number of jobs in the jobset. | ||
| JobIDKey string = "jobset.sigs.k8s.io/job-id" |
There was a problem hiding this comment.
i would call it jobset.sigs.k8s.io/job-global-index
There was a problem hiding this comment.
Makes sense, updated PR accordingly.
danielvegamyhre
force-pushed
the
job-id
branch
2 times, most recently
from
18c7fb6 to
7544e12
Compare
danielvegamyhre
force-pushed
the
job-id
branch
from
7544e12 to
c5dc122
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649