Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0 in the kubernetes group #662

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2024

Bumps the kubernetes group with 1 update: sigs.k8s.io/controller-runtime.

Updates sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.19.0

⚠️ Deprecation Warnings

Please note that admission.Defaulter/Validator have been deprecated in favor of admission.CustomDefaulter/CustomValidator since v0.17 and will be removed with v0.20.

⚠️ Breaking Changes

✨ New Features

  • client: Add WithFieldValidation client (#2860 #2913)
  • controller & webhook: Recover panics per default & add panic metrics (#2905)
  • controllerutil: configure BlockOwnerDeletion when setting OwnerReference (#2847)
  • fake client: Add scale subresource logic (#2855)
  • predicate: Add missing generic version of ResourceVersionChangedPredicate (#2812)
  • setup-envtest: Download binaries from controller-tools releases instead of GCS (#2811)
  • setup-envtest: Publish setup-envtest binaries via release attachments (#2911)
  • workqueue: Add controller label to workqueue metrics (#2895)

🐛 Bug Fixes

  • apiutil.IsGVKNamespaced: Fix namespaced GVK check to use version (#2875)
  • cache: Fix label defaulting of byObject when namespaces are configured (#2805)
  • certwatcher: Recreate watcher if the file is unlinked and replaced (#2893)
  • manager: Fix log in AddMetricsServerExtraHandler (#2874)
  • manager: Quiet context.Canceled errors during shutdown (#2745)
  • manager: Reintroduce AddMetricsServerExtraHandler (#2813)
  • manager.Start: Prevent LeaderElector setup error from being swallowed (#2876)
  • source.Kind: String() should return correct type (#2806)

🌱 Others

  • actions: Add action to approve actions if /ok-to-test is set (#2908)
  • controller: Add dynamic watcher tests (#2881)
  • dependabot: disable go module bumps, bump all actions in a single PR (#2856)
  • verify-modules: Verify go modules are in sync with upstream k/k (#2774)

📖 Additionally, there have been 5 contributions to our documentation. (#2830, #2849, #2863, #2894, #2899, #2910)

Dependencies

Added

  • cel.dev/expr: v0.15.0
  • github.com/antlr4-go/antlr/v4: v4.13.0

... (truncated)

Commits
  • b901db1 Merge pull request #2924 from lucacome/bump-deps
  • 0c7827e Bump k8s.io deps to v1.31.0
  • 9f5afec Merge pull request #2918 from sbueringer/pr-add-skip-name-validation
  • 96e8152 Merge pull request #2921 from kubernetes-sigs/dependabot/github_actions/all-g...
  • 8f5faff 🌱 Bump actions/upload-artifact in the all-github-actions group
  • 89bebe3 Add SkipNameValidation option
  • 7857623 Merge pull request #2911 from sbueringer/pr-publish-setup-envtest
  • fdc8bd7 Merge pull request #2913 from sbueringer/pr-test-cov-field-validation
  • 7dfd3bb Fix WithFieldValidation client
  • e882354 Merge pull request #2908 from sbueringer/pr-approve-action
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign danielvegamyhre for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kannon92 August 26, 2024 04:10
@k8s-ci-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 0e61a3c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66d37cb9b5151000084c8090

Bumps the kubernetes group with 1 update: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime).


Updates `sigs.k8s.io/controller-runtime` from 0.18.4 to 0.19.0
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.18.4...v0.19.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: kubernetes
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/kubernetes-f063580984 branch from 4cf0761 to 0e61a3c Compare August 31, 2024 20:27
@k8s-ci-robot
Copy link
Contributor

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-jobset-test-integration-main 0e61a3c link true /test pull-jobset-test-integration-main
pull-jobset-test-e2e-main-1-29 0e61a3c link true /test pull-jobset-test-e2e-main-1-29
pull-jobset-test-e2e-main-1-28 0e61a3c link true /test pull-jobset-test-e2e-main-1-28
pull-jobset-test-e2e-main-1-31 0e61a3c link true /test pull-jobset-test-e2e-main-1-31
pull-jobset-test-unit-main 0e61a3c link true /test pull-jobset-test-unit-main
pull-jobset-test-e2e-main-1-30 0e61a3c link true /test pull-jobset-test-e2e-main-1-30
pull-jobset-verify-main 0e61a3c link true /test pull-jobset-verify-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 1, 2024

@kannon92 any idea what changed to cause this to fail and how we can fix it?

@kannon92
Copy link
Contributor

kannon92 commented Sep 1, 2024

I am not sure. This is also bumping the k8s updates so that is probably why it is failing. Those are usually manual updates.

@kannon92
Copy link
Contributor

kannon92 commented Sep 1, 2024

@mbobrovskyi you did a big update for 1.31 for Kueue. Do you know what we need to do to upgrade to 1.31?

It looks like there are two issues I see. One is something to do with feature gates and the other seems to some code fixing for the codegen.

@mbobrovskyi
Copy link
Contributor

@mbobrovskyi you did a big update for 1.31 for Kueue. Do you know what we need to do to upgrade to 1.31?

It looks like there are two issues I see. One is something to do with feature gates and the other seems to some code fixing for the codegen.

Yes, this is the biggest changes. I can prepare PR to upgrade it.

@kannon92
Copy link
Contributor

kannon92 commented Sep 1, 2024

Thank you so much!

Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 2, 2024

Looks like sigs.k8s.io/controller-runtime is no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Sep 2, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/kubernetes-f063580984 branch September 2, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants