-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0 in the kubernetes group #662
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
Bumps the kubernetes group with 1 update: [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime). Updates `sigs.k8s.io/controller-runtime` from 0.18.4 to 0.19.0 - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.18.4...v0.19.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes ... Signed-off-by: dependabot[bot] <support@github.com>
4cf0761
to
0e61a3c
Compare
@dependabot[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@kannon92 any idea what changed to cause this to fail and how we can fix it? |
I am not sure. This is also bumping the k8s updates so that is probably why it is failing. Those are usually manual updates. |
@mbobrovskyi you did a big update for 1.31 for Kueue. Do you know what we need to do to upgrade to 1.31? It looks like there are two issues I see. One is something to do with feature gates and the other seems to some code fixing for the codegen. |
Yes, this is the biggest changes. I can prepare PR to upgrade it. |
Thank you so much! |
Looks like sigs.k8s.io/controller-runtime is no longer updatable, so this is no longer needed. |
Bumps the kubernetes group with 1 update: sigs.k8s.io/controller-runtime.
Updates
sigs.k8s.io/controller-runtime
from 0.18.4 to 0.19.0Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
... (truncated)
Commits
b901db1
Merge pull request #2924 from lucacome/bump-deps0c7827e
Bump k8s.io deps to v1.31.09f5afec
Merge pull request #2918 from sbueringer/pr-add-skip-name-validation96e8152
Merge pull request #2921 from kubernetes-sigs/dependabot/github_actions/all-g...8f5faff
🌱 Bump actions/upload-artifact in the all-github-actions group89bebe3
Add SkipNameValidation option7857623
Merge pull request #2911 from sbueringer/pr-publish-setup-envtestfdc8bd7
Merge pull request #2913 from sbueringer/pr-test-cov-field-validation7dfd3bb
Fix WithFieldValidation cliente882354
Merge pull request #2908 from sbueringer/pr-approve-actionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions