Propagate schedulingGates set on PodTemplate when resuming JobSet #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
k8s-ci-robot
added
the
size/M
mimowo
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
mimowo
force-pushed
the
propagate-scheduling-gates
branch
3 times, most recently
from
cafc188 to
54c8baa
Compare
mimowo
force-pushed
the
propagate-scheduling-gates
branch
from
54c8baa to
64a54c9
Compare
mimowo
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @kannon92 @danielvegamyhre |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@ahg-g can we cherry-pick to 0.7.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
To support integration with Kueue for TAS.
Special notes for your reviewer:
I mark the PR as a bug because this was my intention while working on #623, but I forgot to actually propagate them (merge) back then. The previous PR on its own isn't enough.
Now I realized the issue exists while working on TAS for Kueue, which is using the
ueue.x-k8s.io/topologyscheduling gate. See here.It will be great to cherry-pick to 0.7.1 or even 0.6.1
Does this PR introduce a user-facing change?