Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync go1.19 changes from encoding/json #17

Merged
merged 2 commits into from
Nov 16, 2022
Merged

sync go1.19 changes from encoding/json #17

merged 2 commits into from
Nov 16, 2022

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Nov 12, 2022 

git log --format=oneline upstream/release-branch.go1.18..upstream/release-branch.go1.19 -- src/encoding/json/

46ab7a5c4f80d912f25b6b3e1044282a2a79df8b encoding/json: mention SyntaxError in Unmarshal doc comment
19309779ac5e2f5a2fd3cbb34421dafb2855ac21 all: gofmt main repo
81431c7aa7c5d782e72dec342442ea7664ef1783 all: replace `` and '' with “ (U+201C) and ” (U+201D) in doc comments
690ac4071fa3e07113bf371c9e74394ab54d6749 all: remove trailing blank doc comment lines
5a03cbd12a2fcaf85482f1f4d9570c064510da9b encoding/json: use reflect.Value.UnsafePointer over Pointer

@liggitt
sync go1.19 changes from encoding/json
a72174c 
git log --format=oneline upstream/release-branch.go1.18..upstream/release-branch.go1.19 -- src/encoding/json/
46ab7a5c4f80d912f25b6b3e1044282a2a79df8b encoding/json: mention SyntaxError in Unmarshal doc comment
19309779ac5e2f5a2fd3cbb34421dafb2855ac21 all: gofmt main repo
81431c7aa7c5d782e72dec342442ea7664ef1783 all: replace `` and '' with “ (U+201C) and ” (U+201D) in doc comments
690ac4071fa3e07113bf371c9e74394ab54d6749 all: remove trailing blank doc comment lines
5a03cbd12a2fcaf85482f1f4d9570c064510da9b encoding/json: use reflect.Value.UnsafePointer over Pointer
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2022
@liggitt
Copy link
Contributor Author

liggitt commented Nov 12, 2022

cc @apelisse @alexzielenski

@apelisse
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bc3834c into kubernetes-sigs:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@apelisse apelisse

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @apelisse @k8s-ci-robot