add one more test case

Signed-off-by: Marius Kimmina <marius@adjoe.io>
kubernetes-sigs · Oct 21, 2024 · 688404d · 688404d
1 parent 422151e
commit 688404d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/pkg/apis/v1/nodeclaim.go b/pkg/apis/v1/nodeclaim.go
@@ -73,7 +73,7 @@ type NodeClaimSpec struct {
 	// +kubebuilder:validation:Schemaless
 	// +optional
 	ExpireAfter NillableDuration `json:"expireAfter,omitempty"`
-	// unreachableTimeout is the duration the controller will wait
+	// UnreachableTimeout is the duration the controller will wait
 	// before terminating a node, measured from when the node is tainted unreachable
 	// +kubebuilder:default:="Never"
 	// +kubebuilder:validation:Pattern=`^(([0-9]+(s|m|h))+)|(Never)$`

diff --git a/pkg/controllers/nodeclaim/notready/suite_test.go b/pkg/controllers/nodeclaim/notready/suite_test.go
@@ -115,4 +115,10 @@ var _ = Describe("NotReady", func() {
 		ExpectObjectReconciled(ctx, env.Client, notReadyController, nodeClaim)
 		nodeClaim = ExpectExists(ctx, env.Client, nodeClaim)
 	})
+	It("should not remove the NodeClaim when UnreachableTimeout is disabled", func() {
+		nodeClaim.Spec.ExpireAfter = v1.MustParseNillableDuration("Never")
+		ExpectApplied(ctx, env.Client, nodeClaim)
+		ExpectObjectReconciled(ctx, env.Client, notReadyController, nodeClaim)
+		nodeClaim = ExpectExists(ctx, env.Client, nodeClaim)
+	})
 })