Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Fits function to check that total values are non-negative #189

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix: Fix Fits function to check that total values are non-negative #189

merged 1 commit into from
Jan 31, 2023

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jan 31, 2023 •
edited
Loading

Fixes #

Description

  • Fix Fits function to check that total values are non-negative

Discovered through investigation on aws/karpenter-provider-aws#3302

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 31, 2023 18:58
@jonathan-innis jonathan-innis requested a review from tzneal January 31, 2023 18:58
@coveralls
Copy link

coveralls commented Jan 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4057398122

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 79.433%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/resources/resources.go 3 5 60.0%
Totals Coverage Status
Change from base Build 4050137047: 0.05%
Covered Lines: 6415
Relevant Lines: 8076
💛 - Coveralls

@jonathan-innis jonathan-innis enabled auto-merge (squash) January 31, 2023 19:44
@jonathan-innis jonathan-innis changed the title bug: Fix Fits function to check that total values are non-negative fix: Fix Fits function to check that total values are non-negative Jan 31, 2023
engedaam
engedaam approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 558e8c5 into kubernetes-sigs:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @engedaam