-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kubernetes subprojects off of deprecated flags #3717
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
Comments
k8s-ci-robot
added
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
labels
Aug 16, 2024
This was referenced Aug 20, 2024
we're waiting for kubernetes-csi/csi-release-tools#259 and then we will have to revisit the other kubernetes-csi* repos, thanks @stmcginnis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
There are a number of places that kubernetes subprojects are still using
--kube-root
or--loglevel
withkind
:https://cs.k8s.io/?q=--kube-root&i=nope&files=&excludeFiles=&repos=
These flags are deprecated and we should migrate the usage.
For
--kube-root
, the value should be the first non-flag argument tokind build node-image
instead.For
--loglevel
, an appropriate verbosity should be set instead with-v
https://github.com/kubernetes-sigs/kind/pull/3716/files#diff-2740c7f56a6f791e3b58762614a3e84f6225b1df7531b792bebb1bb45f4b6b41L98-L101
/kind cleanup
/sig testing
The text was updated successfully, but these errors were encountered: