-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
images/base: disable udev.service #1948
Conversation
Hi @AkihiroSuda. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
79b9b9e
to
12fd3be
Compare
Failure of Podman CI seems unrelated
|
@BenTheElder PTAL |
podman CI is indeed broken atm (breaking podman changes...) aojea is on it
I took tonight to work on the out of sync contributor guide mostly, I'll
get back to PR review in the morning 😅
…On Thu, Dec 3, 2020 at 1:20 AM Akihiro Suda ***@***.***> wrote:
@BenTheElder <https://github.com/BenTheElder> PTAL
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1948 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK4D2PAI4EVUBFHCTETSS5J5PANCNFSM4UIU466A>
.
|
fixed by #1790 |
fix is merged now, but I'm off to exercise the pup. will review tonight. also, github actions requires that we rebase this PR to pick up the fix, unlike prow 😞 |
12fd3be
to
2473cab
Compare
thanks, rebased |
/ok-to-test |
/lgtm |
ping maintainers |
@BenTheElder we need to bump the image on #1979 , so I think we should have this in before that lands |
I did the bump push. I did not add it to the PR because everything is on hold pending the fact that we seem to have broken kind in github actions. |
#1969 should be resolved, finally 🤞 |
Discussed in kubernetes-sigs#1935 (comment) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2473cab
to
42761be
Compare
rebased |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Discussed in #1935 (comment)