Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Multi node config" #204

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Conversation

BenTheElder
Copy link
Member

Reverts #147

this PR was incompatible with https://github.com/kubernetes-sigs/kind/pull/164/commits, I'd rather merge that and get onto fixing up rebase etc.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2019
@krzyzacy
Copy link

krzyzacy commented Jan 8, 2019

/pony shrug
/lgtm

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: pony image

In response to this:

/pony shrug
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@BenTheElder BenTheElder merged commit 0636092 into master Jan 8, 2019
@BenTheElder BenTheElder deleted the revert-147-multi-node-config branch January 8, 2019 22:32
@neolit123
Copy link
Member

neolit123 commented Jan 9, 2019

this PR was incompatible with https://github.com/kubernetes-sigs/kind/pull/164/commits

i think the action PR was supposed to merge after the multi-node PR.
might have been better to allow @fabriziopandini to rebase.

@BenTheElder
Copy link
Member Author

@neolit123 perhaps, trying to unclog the backlog though. I also have a number of not yet PRed changes that we should get in, besides the outstanding backlog. In either case I will be filing more PRs to the config format before the next release (IE today).

@neolit123
Copy link
Member

kk, sounds good.

stg-0 pushed a commit to stg-0/kind that referenced this pull request Aug 9, 2023
* Bump cluster-api-provider-aws

* Remove change image in infracomponent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants