-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch all CI to make #2104
switch all CI to make #2104
Conversation
uh oh:
fyi @aojea we're hitting rate limits in github actions now: #1895 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
if [ "${BUILD_TYPE:-}" = "bazel" ]; then | ||
build_with_bazel | ||
else | ||
#if [ "${BUILD_TYPE:-}" = "bazel" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
older branches? and/or delete completely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leaving the most trivial revertable state, will come back and fully delete these code paths from more than just the script once I get a chance to confirm the state of CI.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
xref: kubernetes/enhancements#2420
building should be fine on previous branches, we still have plenty of bazel coverage for those in other jobs, after this goes through we can wind down our own bazel tech-debt here.
bazel already doesn't work for some older branches with kind