-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump containerd and cri-tools to latest #2207
Conversation
Hi @MaXinjian. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
is there any particular change noteworthy in these tools? |
cri-tools #724 is meaningful |
/ok-to-test |
/retest |
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
images/base/Dockerfile
Outdated
@@ -28,24 +28,24 @@ ARG TARGETARCH | |||
|
|||
# Configure containerd and runc binaries from kind-ci/containerd-nightlies repository | |||
# The repository contains latest stable releases and nightlies built for multiple architectures | |||
ARG CONTAINERD_VERSION="1.5.0-beta.4-91-g1b05b605c" | |||
ARG CONTAINERD_VERSION="1.5.0-rc.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final 1.5.0 was released 3 days ago
https://github.com/containerd/containerd/releases/tag/v1.5.0
/lgtm @BenTheElder do we want to handle this bump independently or should we wait for the release? |
/test pull-kind-e2e-kubernetes-1-20 |
I would like us to bump to 1.5.0 for the release |
working on the image(s) for this. |
for reference @aojea:
|
Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
sorry i've been semi-unavailable myself. mostly had time for a few breaking bugs and otherwise been ~out. |
/approve |
/hold we should investigate if this bumps us to runc rc93 or not, rc93 has serious performance regression with kubelet apparently that is fixed in rc94 which is still be rolled out to projects like containerd |
containerd/containerd@de6db40 seems to only be at HEAD containerd/containerd#5473 and containerd 1.5.0 was definitely released with rc93, not sure if it was at rc93 in the version we already have. |
👍 |
containerd/containerd@v1.5.0...master looks like we should just bump to HEAD instead of sticking to the nice tagged release. current head is not far ahead, looks like mostly bug fixes. |
containerd 1.5.1 will roll out in a day or so @BenTheElder @aojea |
thanks that's good to know. |
kind-ci/containerd-nightlies@fe50612 the nightly build needed to cover the 1.5 branch, updated that and kicked off an earlier build so we can pick it up (scheduled builds are nightly) |
1.5.0-17-g799eef87c is now available, HEAD of release/1.5 branch. |
@BenTheElder 1.5.1 is out and it uses runc rc94 !! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, MaXinjian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ma Xinjian maxj.fnst@fujitsu.com