Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] DO NOT MERGE: rootless CI, test Kubernetes PR 111513 #2851

Closed
wants to merge 2 commits into from
Closed

[WIP] DO NOT MERGE: rootless CI, test Kubernetes PR 111513 #2851

wants to merge 2 commits into from

Conversation

BenTheElder
Copy link
Member

the testing part of #2846 without the kind code change

this should fail in rootless, in theory ...

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from amwat and neolit123 August 2, 2022 01:09
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2022
@BenTheElder
Copy link
Member Author

This is the part we care about https://github.com/kubernetes-sigs/kind/runs/7622897790?check_suite_focus=true

@BenTheElder BenTheElder mentioned this pull request Aug 2, 2022
Merged
@BenTheElder
Copy link
Member Author

pushing an image built locally so we can skip the lengthy build step and get results in rootless CI without timeouts

@BenTheElder BenTheElder force-pushed the localstoragenofield branch from e0fbf67 to 49fe0b4 Compare August 2, 2022 18:48
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2022
@BenTheElder
Copy link
Member Author

switched to a pre-built image so we can get actual rootless CI results hopefully

@BenTheElder BenTheElder force-pushed the localstoragenofield branch from 49fe0b4 to 640f983 Compare August 2, 2022 18:58
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2022
@BenTheElder
Copy link
Member Author

confirmed that it fails without #2851 https://github.com/kubernetes-sigs/kind/runs/7638281019?check_suite_focus=true

confirming again that it passes with #2851 included ...

@BenTheElder
Copy link
Member Author

can confirm https://github.com/kubernetes-sigs/kind/runs/7638447115?check_suite_focus=true

localStorageCapacityIsolation: false

@BenTheElder BenTheElder closed this Aug 2, 2022
@BenTheElder BenTheElder deleted the localstoragenofield branch August 2, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat Awaiting requested review from amwat

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenTheElder @k8s-ci-robot