Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve contributor docs #314

Merged
merged 3 commits into from
Feb 18, 2019
Merged

improve contributor docs #314

merged 3 commits into from
Feb 18, 2019

Conversation

BenTheElder
Copy link
Member

  • ungroup tool installs, most everyone should install git... generally improve the getting started guide
  • add many links and a few more details to the scope document

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2019
@BenTheElder
Copy link
Member Author

these docs both still need work. this should help a little.

@tao12345666333
Copy link
Member

I also happened to think of this part, I pushed an image last night.

The source code https://github.com/tao12345666333/kindenv .

Do we need to provide a standard development environment, like the moby project's development environment?

@BenTheElder
Copy link
Member Author

BenTheElder commented Feb 18, 2019 •
edited
Loading

Do we need to provide a standard development environment, like the moby project's development environment?

I don't think that's necessary currently. We just require a reasonably up-to-date Go install and the same Docker install requirements as using kind.
Git probably isn't worth containerizing just for kind, and Hugo is fairly optional since we have the previews and the main sources are just markdown.

@tao12345666333
Copy link
Member

I agree with you. 👍

The original intention of this project was to add a timing build task for CI. Auto build node image synchronized with the upstream version of kubernetes

@BenTheElder
Copy link
Member Author

Ooh, related to https://github.com/kubernetes-sigs/kind/issues ? 👀

@BenTheElder
Copy link
Member Author

/retest

@tao12345666333
Copy link
Member

xref: #197

neolit123
neolit123 reviewed Feb 18, 2019
View reviewed changes
site/content/docs/contributing/getting-started.md Outdated
You can check if `git` is already on your system and properly installed with
the following command:

```
git --version
```
This documentation is written using `git` version 2.17.1.
This documentation is written using `git` version `2.17.1`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

written -> managed?

also possibly no need to add this sentence?
users without git will land with a fairly new and compatible git package as a download.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, this was already in the doc, I only changed the command / version markup to match. Will remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@neolit123
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019
@BenTheElder
Copy link
Member Author

/pony monday

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: pony image

In response to this:

/pony monday

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit c19293d into kubernetes-sigs:master Feb 18, 2019
@BenTheElder BenTheElder deleted the more-contributor-docs branch February 18, 2019 20:17
stg-0 pushed a commit to stg-0/kind that referenced this pull request Oct 2, 2023
@kahun
[CLOUD-80] Utilizar azure driver v1.10 para Azure unmanaged (kubernet…
3fe0ad2 
…es-sigs#314)

* Fix azure provider managed

* Fix merge

* Change order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @tao12345666333 @neolit123